Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Missing Linux launch related Spanish localizations #242

Open
0neGal opened this issue Jul 23, 2024 · 1 comment
Open

bug: Missing Linux launch related Spanish localizations #242

0neGal opened this issue Jul 23, 2024 · 1 comment
Labels
bug Something isn't working localization Related to localization

Comments

@0neGal
Copy link
Owner

0neGal commented Jul 23, 2024

It seems I managed to miss this when merging #229, but the Spanish localizations only has 2 of the titles for the new toasts instead of all of them + the text... This is where I recommend using npm run langs:localize over manually editing :p

Though, I suppose this is my fault for never getting around to making some CI/CD for checking localizations... This is now added with 5ddec75

Specifically these are missing (@XNovaDelta):

es.json is missing:
  gui.toast.title.missing_steam
  gui.toast.title.missing_flatpak
  gui.toast.title.missing_flatpak_steam
  gui.toast.desc.failed_launch_command
  gui.toast.desc.missing_launch_command
  gui.toast.desc.missing_steam
  gui.toast.desc.missing_flatpak
  gui.toast.desc.missing_flatpak_steam
@0neGal 0neGal added bug Something isn't working localization Related to localization labels Jul 23, 2024
@0neGal
Copy link
Owner Author

0neGal commented Jul 23, 2024

Well, I got curious, and discovered I accidentally broke the checking of the localization files when publishing a build (ccde19d8), the entire reason why I never noticed this when releasing, that issue is fixed now: 877d0e5

whoopsie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working localization Related to localization
Projects
None yet
Development

No branches or pull requests

1 participant