Skip to content
This repository has been archived by the owner on Jul 12, 2021. It is now read-only.

Weird way of how userhash is computed #4

Open
mudrd8mz opened this issue Jun 10, 2016 · 0 comments
Open

Weird way of how userhash is computed #4

mudrd8mz opened this issue Jun 10, 2016 · 0 comments

Comments

@mudrd8mz
Copy link

I don't quite understand why are you accessing $_SESSION to get to the current sesskey value in the classes/deviceanalytics_data_storage_class.php. Is not simple sesskey() enough? Note that direct access to superglobals is discouraged in Moodle plugins code.

Also, why are you doing sha1(md5($usersession)); and then MD5 once again? Why not simple use sha1(sesskey()) as the session hash?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant