Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail on tag mismatch #85

Open
KevinBatdorf opened this issue Feb 23, 2022 · 1 comment
Open

Fail on tag mismatch #85

KevinBatdorf opened this issue Feb 23, 2022 · 1 comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.

Comments

@KevinBatdorf
Copy link

Is your enhancement related to a problem? Please describe.

If you mistakenly forget to update the stable tag, the deploy will happen but .org won't pick up the new version. This is never expected.

Describe the solution you'd like

The workflow should fail if the tag doesn't match the stable tag

Describe alternatives you've considered

I could probably write something in the workflow before this action runs but it feels like something the action should handle since there's never a case you would want to push the tag with a mismatched stable tag.

Additional context

I don't think the workflow should update the tag though. It should fail and alert.

@vikrampm1 vikrampm1 added the type:enhancement New feature or request. label Feb 23, 2022
@richard-muvirimi
Copy link
Contributor

Actually having it automatically picked from the stable tag in README as an option would be better. I am aware there is another action for updating the readme, but it's not every plugin that one maintains tags for.

@jeffpaul jeffpaul added the help wanted Extra attention is needed label Mar 20, 2023
@jeffpaul jeffpaul added this to the Future Release milestone Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type:enhancement New feature or request.
Projects
Status: Backlog
Development

No branches or pull requests

4 participants