Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Figma icon #1

Closed
1 task done
dkotter opened this issue Mar 12, 2024 · 3 comments · Fixed by #8
Closed
1 task done

Fix the Figma icon #1

dkotter opened this issue Mar 12, 2024 · 3 comments · Fixed by #8
Labels
type:enhancement New feature or request.
Milestone

Comments

@dkotter
Copy link
Collaborator

dkotter commented Mar 12, 2024

Is your enhancement related to a problem? Please describe.

We show a Figma icon in our Figma Embed block but this icon isn't rendering as well as it should.

I got this file from here: https://www.figma.com/using-the-figma-brand/ and I copied the svg markup and put that directly into https://github.com/10up/figma-block/blob/d397f7e7e074671443162d12f61f0ec8ffcd04bc/src/assets/js/icon.js.

But it seems to be rendering slightly blurry or fuzzy, as you can see from the screenshot: https://github.com/10up/figma-block/blob/5c2b2dd6a66e810d87a869318e26c701f8dff8b2/.wordpress-org/screenshot-1.png

Not exactly sure what needs to change here but I'm guessing some adjustments to the svg markup may be needed for this icon to work properly in the block.

Designs

No response

Describe alternatives you've considered

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dkotter dkotter added the type:enhancement New feature or request. label Mar 12, 2024
@dkotter dkotter added this to the 0.1.0 milestone Mar 12, 2024
@dkotter
Copy link
Collaborator Author

dkotter commented Mar 12, 2024

For now I've switched over to using the black icon as it doesn't seem to have the same issue (or at least my eyes can't see an issue with it).

The assets Figma provides includes a black icon, white icon and color icon. I've added all three of these into our icons file: https://github.com/10up/figma-block/blob/develop/src/assets/js/icon.js so it's easy to try out different ones if we want.

Personally I think the color icon looks the best so would still be great to figure out how we can use that.

@faisal-alvi
Copy link
Member

I've used IconColor and it does not look blurry or fuzzy for me.

image

image

@jeffpaul
Copy link
Member

@faisal-alvi that looks good to me, want to push that up as a PR for review/merge?

@faisal-alvi faisal-alvi mentioned this issue Apr 15, 2024
4 tasks
@faisal-alvi faisal-alvi moved this from Incoming to Code Review in Open Source Practice Apr 15, 2024
@github-project-automation github-project-automation bot moved this from Code Review to Merged in Open Source Practice Apr 15, 2024
@jeffpaul jeffpaul moved this from Merged to Done in Open Source Practice Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants