Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title attribute absent for accessibility #37

Open
inetbiz opened this issue Mar 16, 2022 · 6 comments
Open

Title attribute absent for accessibility #37

inetbiz opened this issue Mar 16, 2022 · 6 comments

Comments

@inetbiz
Copy link

inetbiz commented Mar 16, 2022

I propose the eleventyNavigation use the title attribute to also create the HTML title attribute. It's not perfect. Som screen readers will override with aria-label if present. https://developers.google.com/web/fundamentals/accessibility/semantics-aria/aria-labels-and-relationships. IF the title attribute is present in a link, the screen reader will use it.
eleventyNavigation with title

@inetbiz inetbiz changed the title ARIA Title attribute absent Title attribute absent for accessibility Mar 16, 2022
@inetbiz
Copy link
Author

inetbiz commented Mar 16, 2022

This should also be included in the eleventyNavigationBreadcrumb function.

@inetbiz
Copy link
Author

inetbiz commented Mar 16, 2022

I would consider these enhancements to be urgent. Considerations for the needs of those whom are impaired.

@rileymacisaac
Copy link

Out of curiosity, where would you imagine the title attribute be added? Adding the title or aria-label attribute to a link when plain text is provided is irrelevant and not recommended.

For example:
Use this:
<a href="#">All of the mammals</a>

Not this:
<a href="#" title="All of the mammals">All of the mammals</a>

@inetbiz
Copy link
Author

inetbiz commented Mar 18, 2022

The whole reason for adding title or ARIA-label are for screen readers; for the visually impaired.

@rileymacisaac
Copy link

I'm a certified accessibility professional, and I understand where you are coming from, but I'm trying to communicate that adding titles and/or aria-labels with the same value as text already provided in the HTML provides no extra value to a screen reader or other assistive tech.

All you need to communicate a link is text in the anchor.

If you'd like to add additional attributes or roles you can always render the navigation manually.

@inetbiz
Copy link
Author

inetbiz commented Mar 30, 2022

Not all Links contain the text. Examples are Links that may say, "Here" or "More".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants