Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format in grade setting example #49

Open
drlippman opened this issue Jul 1, 2020 · 0 comments
Open

Date format in grade setting example #49

drlippman opened this issue Jul 1, 2020 · 0 comments

Comments

@drlippman
Copy link

In the example of how to use the grade service, the readme has

->set_timestamp(date(DateTime::ISO8601))

But the AGS specs say "Timestamp values MUST be formatted using ISO 8601 with a sub-second precision." and the DateTime::ISO8601 format does not include sub-second precision. Also (at least according to php manual) DateTime::ISO8601 isn't actually iso8601 compatible.

I'm guessing most platforms can handle the dates as this example sets them so it's probably OK, but I think a more accurate timestamp setting would be:

->set_timestamp(date('Y-m-d\TH:i:s.uP'))

which is the DateTime::ATOM format with the addition of sub-seconds.

JanHolger pushed a commit to JanHolger/lti-1-3-php-library that referenced this issue Jul 26, 2022
…o-composer

SEC-64 Add Apache license to composer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant