Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click and dragging a card for a few seconds leads to warning and then freezes #144

Closed
edmondtam1 opened this issue Mar 10, 2023 · 3 comments

Comments

@edmondtam1
Copy link

Hi,

Thank you for the lovely component! It's wonderfully simple to use and implement.

Problem

On my website and the test website (https://3djakob.github.io/react-tinder-card-demo/), there is a warning that appears after holding onto a card (and shaking it a little) for too long:

image

After this warning, the card freezes and then disappears.

Other context

I'm wondering if this is due to any updates to React or its compatibility with @react-spring? This guess is based on this issue on react-timekeeper here: catc/react-timekeeper#85.

It doesn't happen when using the demos in @react-spring, however (see https://www.react-spring.dev/examples).

Any ideas on how we can address this will be very much appreciated, and thanks again for the package!

@3DJakob
Copy link
Owner

3DJakob commented Sep 22, 2023

Hey @edmondtam1 sorry for the very late reply. But I noticed this as well. Perhaps this would be resolved if the spring version was updated. I will look at it, but if someone beats me to it PRs are welcome.

@3DJakob
Copy link
Owner

3DJakob commented Sep 22, 2023

@edmondtam1 This has been fixed in 1.5.3. Just update and it will work! 👍

@3DJakob 3DJakob closed this as completed Sep 22, 2023
@edmondtam1
Copy link
Author

Appreciate it a lot, thank you @3DJakob!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants