-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CTFFIND5 support #1088
Comments
Will CTFFIND4 remain available, or will they replace CTFFIND4 with CTFFIND5? Will the additional "no" break CTFFIND4 compatibility? |
I don't know. AFAICT currently the only source of a CTFFIND5 binary is pulling it out of a cisTEM tarball but that executable can be called from RELION with looking at so yes I think it probably could break compatibility? |
If adding another "no" works for both versions, I am happy to add. Otherwise, this will remain low priority as long as people can get CTFFIND4; we don't need/support CTFFIND5's new features. Of course we can parse CTFFIND's header and determine the version, but it will be another layer of complexity & a point of failure. If someone sends us a pull request, I am happy to merge, but I myself won't implement it. |
Yes sure. It's pretty clear from the RELION GUI that the support is for CTFFIND4 and that the new version is CTFFIND5. If it becomes clear that CTFFIND5 is easily available outside of cisTEM and SPA users want to use it I'll send a PR but I think this would be a new Presumably RELION-5 tomo will support the new CTFFIND features? |
Hey, just wanted to chime in that if you need any help from our side, whether it is about how to call ctffind (which I know is a bit bothersome) or how to grab the binaries of whatever version, feel free to ping me, email me, or open an issue at our repo Best, Johannes |
I added some code to support CtfFind5 in my relion fork: P.S. currently its still missing GUI |
even for no new feature support
CTFFIIND4
->CTFFIND5
is not a drop in replacement: it needs an extrano
in the script that RELION writes.I'm sure RELION team have plans to support the new version so opening this as a placeholder.
The text was updated successfully, but these errors were encountered: