Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CTFFIND5 support #1088

Open
huwjenkins opened this issue Mar 2, 2024 · 6 comments
Open

CTFFIND5 support #1088

huwjenkins opened this issue Mar 2, 2024 · 6 comments

Comments

@huwjenkins
Copy link
Contributor

even for no new feature support CTFFIIND4 -> CTFFIND5 is not a drop in replacement: it needs an extra no in the script that RELION writes.

I'm sure RELION team have plans to support the new version so opening this as a placeholder.

@biochem-fan
Copy link
Member

Will CTFFIND4 remain available, or will they replace CTFFIND4 with CTFFIND5?

Will the additional "no" break CTFFIND4 compatibility?

@huwjenkins
Copy link
Contributor Author

Will CTFFIND4 remain available, or will they replace CTFFIND4 with CTFFIND5?

I don't know. AFAICT currently the only source of a CTFFIND5 binary is pulling it out of a cisTEM tarball but that executable can be called from RELION with --ctffind_exe

looking at /src/ctffind_runner.cpp The extra question is "Determine samnple thickness? : no"

so yes I think it probably could break compatibility?

@biochem-fan
Copy link
Member

If adding another "no" works for both versions, I am happy to add.
(If it is the last question, CTFFIND4 won't complain)

Otherwise, this will remain low priority as long as people can get CTFFIND4; we don't need/support CTFFIND5's new features. Of course we can parse CTFFIND's header and determine the version, but it will be another layer of complexity & a point of failure. If someone sends us a pull request, I am happy to merge, but I myself won't implement it.

@huwjenkins
Copy link
Contributor Author

huwjenkins commented Mar 2, 2024

Yes sure. It's pretty clear from the RELION GUI that the support is for CTFFIND4 and that the new version is CTFFIND5. If it becomes clear that CTFFIND5 is easily available outside of cisTEM and SPA users want to use it I'll send a PR but I think this would be a new CTFFIND5 tab with quite a bit of extra code because (is_ctffind4) is in quite a few places in src/ctffind_runner.cpp

Presumably RELION-5 tomo will support the new CTFFIND features?

@jojoelfe
Copy link

jojoelfe commented Mar 3, 2024

Hey,

just wanted to chime in that if you need any help from our side, whether it is about how to call ctffind (which I know is a bit bothersome) or how to grab the binaries of whatever version, feel free to ping me, email me, or open an issue at our repo

Best,

Johannes

@Poko18
Copy link

Poko18 commented Mar 21, 2024

I added some code to support CtfFind5 in my relion fork:

P.S. currently its still missing GUI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants