Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to hide/remove the injected line with the "scan" and "try it" action links #33

Open
Osndok opened this issue Feb 24, 2023 · 5 comments

Comments

@Osndok
Copy link

Osndok commented Feb 24, 2023

I don't recall when these appeared, but I find these two links to be quite bothersome. Relatedly, neither one is functional, so I don't get any utility from their presence either. There presence greatly disrupts the document which is otherwise a homogenous field of inert, selectable, and mutable text.

Alternatively, perhaps they should be hidden by default unless 42Crunch credentials are present?

For context, as one who primarily values this plugin simply to "linkify" the yaml references, I am currently debating whether the added nuisance of these floaty widgets in the text file outweighs the value-add of the reference-linking feature. My hope is that it is just going through an awkward phase of life.

@vfateev
Copy link
Collaborator

vfateev commented Mar 6, 2023

If we are talking about scan links you are right, it should be hidden by default, unfortunately there was an internal technical reason not to do it. But of course in future releases we will add the possibility to hide them if a user doesn't have the credentials. Right now they can be turned off in Settings / Editor / Inlay Hints / Other / JSON or YAML / Conformance Scan.
As for try it links, they don't depend on the credentials and it is quite useful for our customers that is why it is enabled by default. We will add the possibility to hide them as well. Thank you for your opinion.

@karelhusa
Copy link

@vfateev, I have turned off the Conformance Scan Inlay hints, but the hints still appear in the editor.

No change happened, even after restarting PyCharm. Both Scan and Try it marks are present in the editor.

@vfateev
Copy link
Collaborator

vfateev commented Mar 28, 2023

No need to restart, just press the apply & ok buttons, if it doesn't work like that, then it is a PyCharm issue.

@karelhusa
Copy link

@vfateev With apply & ok buttons, no change.

It's hard to distinguish if the issue resides in the plugin or PyCharm itself. Also, if I report the issue to JetBrains, they do not support 3rd party plugins.

If you have any advice on how to solve such issues, please let me know.

@ak1394
Copy link
Contributor

ak1394 commented Mar 28, 2023

It looks like this is something for us to look at. We'll re-test with PyCharm, and if the issue persists we'll open an issue at IntelliJ bug tracker, for them to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants