Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadatagroups with certain security configuration not possible #86

Open
floriangantner opened this issue Apr 23, 2024 · 0 comments
Open
Labels

Comments

@floriangantner
Copy link

floriangantner commented Apr 23, 2024

Describe the bug
It's hard to save new created metadatagroups with some security level when the leading metadatagroup field has some authority. The choosen security level is not transferred to the Rest API.

To Reproduce
Steps to reproduce the behavior:

  • Tested with Release dspace-cris-2023.02.03 and the dspace-cris-2023_02_x branch with last commit 6af2398 . We also observed it in dspace-cris-2023.01.01
  1. Configure some metadata group with some authority controlled value as the leading element
  2. Configure security level [2 0] for the leading metadata of the metadatagroup and also for the single members of the metadatagroup (not necessary since 2023.02.02). New metadata should be set not visible by default.
  3. Create some new entry. Set it public
  4. Create some new entry. Set it non-public (2)
  5. Save.

Screenshot from 2024-04-23 15-01-16

Expected behavior
We expect the security level to be set according to the values choosen on the edit-security-toggler

Screenshot from 2024-04-23 15-02-29

The PATCH-request to the database does not reflect on changes of the security-level of newly created elements of some metadatagroup and set the wrong security level.

When reloading the submission form the (non-set) security level values of the saved metadatavalues.

Screenshot from 2024-04-23 15-02-59

Related work
Related to https://github.com/4Science/dspace-angular/blob/dspace-cris-2023_02_x/src/app/shared/form/builder/ds-dynamic-form-ui/ds-dynamic-form-control-container.component.ts and it's addSecurityLevelToMetadata method.

The model.securityLevel contains the choosen value, but the model.value does not contain the security level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant