Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make extraction of attachments for SearchableText optional #26

Open
lukasgraf opened this issue Dec 15, 2014 · 3 comments
Open

Make extraction of attachments for SearchableText optional #26

lukasgraf opened this issue Dec 15, 2014 · 3 comments

Comments

@lukasgraf
Copy link
Member

Currently, any attachments of a mail message get extracted by ftw.mails own SearchableTextExtender.

This is error prone, requires hacks for broken MTAs / MUAs and non-trivial to debug. In setups that already use ftw.tika it's also unnecessary - Tika already extracts full text from mail attachments, and probably does so in a much more reliable way than we can.

I would therefore propose to make this behavior in ftw.mail configurable via a registry entry (defaulting to True (extract attachments)).

An alternative approach would be to check whether ftw.tika is installed, and simply skip the extraction of attachments if it is.

@jone @maethu thoughts?

@jone
Copy link
Member

jone commented Dec 16, 2014

The only use case I see for disabling the behaviour is tika.
Therefore I'd not make it configurable but explicitly check for an installed ftw.tika (unless you see other use cases)...

@lukasgraf
Copy link
Member Author

@tarnap could you look into this if you have some time on your hands?

@lukasgraf lukasgraf assigned ghost Oct 2, 2017
@phgross
Copy link
Member

phgross commented Oct 6, 2017

In GEVER we'll overwrite the SearchableTextExtender anyways (see 4teamwork/opengever.core#2462 (comment)), so there is no need to change the SearchableTextExtender for us.

@jone @maethu if you need this adjustments anyways please coordinate with @tarnap. For now he will not implemented this change.

@phgross phgross unassigned ghost Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants