Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify object path in catalog_unrestricted_get_object #160

Open
jone opened this issue Feb 7, 2018 · 0 comments
Open

Verify object path in catalog_unrestricted_get_object #160

jone opened this issue Feb 7, 2018 · 0 comments
Assignees

Comments

@jone
Copy link
Member

jone commented Feb 7, 2018

The method [UpgradeStep.catalog_unrestricted_get_object]

def catalog_unrestricted_get_object(self, brain):
is used to get an object by a brain. It is unrestricted for combining with an unrestrictedSearchResults call.

Just using .unrestrictedTraverse here could lead to problems with Acquisition and lead to the wrong object when the names are similar to uncles. Therefore the path of the gotten object should be compared to the brain's path. When it does not match, the object was removed the brain can be removed too.

@jone jone self-assigned this Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant