Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The RELEASE_VERSION don't seem to be updated (0.0.0) #27

Open
afbjorklund opened this issue Jan 26, 2025 · 3 comments
Open

The RELEASE_VERSION don't seem to be updated (0.0.0) #27

afbjorklund opened this issue Jan 26, 2025 · 3 comments

Comments

@afbjorklund
Copy link

afbjorklund commented Jan 26, 2025

Seems to mostly affect local builds, since there is a variable in the github flow.

@mirkobrombin
Copy link
Collaborator

The release version is based on the tag at build time

@afbjorklund
Copy link
Author

But only in the github release flow, not locally.

You have to provide RELEASE_VERSION to make...
Something like: git describe --tags | tr -d 'v'

There is nothing in the files, that knows the version.

@mirkobrombin
Copy link
Collaborator

We could move this to the Makefile and make the workflow use it. What do you think @89luca89 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants