diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml index 606b66e6f..6018f7c35 100644 --- a/.github/workflows/go.yml +++ b/.github/workflows/go.yml @@ -38,4 +38,4 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v3.4.0 with: - version: v1.51.2 + version: v1.52.0 diff --git a/cli/list.go b/cli/list.go index 330bb09e2..2a0aae253 100644 --- a/cli/list.go +++ b/cli/list.go @@ -184,9 +184,5 @@ func ListCommand(input ListCommandInput, awsConfigFile *vault.ConfigFile, keyrin fmt.Fprintf(w, "-\t-\t%s\t\n", s) } - if err = w.Flush(); err != nil { - return err - } - - return nil + return w.Flush() } diff --git a/cli/proxy.go b/cli/proxy.go index b6a35a1a6..1ab260614 100644 --- a/cli/proxy.go +++ b/cli/proxy.go @@ -9,7 +9,7 @@ import ( "github.com/alecthomas/kingpin/v2" ) -func ConfigureProxyCommand(app *kingpin.Application, a *AwsVault) { +func ConfigureProxyCommand(app *kingpin.Application) { stop := false cmd := app.Command("proxy", "Start a proxy for the ec2 instance role server locally."). diff --git a/main.go b/main.go index 397fcf04d..fc6b1f708 100644 --- a/main.go +++ b/main.go @@ -23,7 +23,7 @@ func main() { cli.ConfigureExportCommand(app, a) cli.ConfigureClearCommand(app, a) cli.ConfigureLoginCommand(app, a) - cli.ConfigureProxyCommand(app, a) + cli.ConfigureProxyCommand(app) kingpin.MustParse(app.Parse(os.Args[1:])) } diff --git a/vault/credentialprocessprovider_test.go b/vault/credentialprocessprovider_test.go index 78ed9d776..abfa6043a 100644 --- a/vault/credentialprocessprovider_test.go +++ b/vault/credentialprocessprovider_test.go @@ -13,11 +13,11 @@ import ( ststypes "github.com/aws/aws-sdk-go-v2/service/sts/types" ) -func executeFail(process string) (string, error) { +func executeFail(_ string) (string, error) { return "", errors.New("executing process failed") } -func executeGetBadJSON(process string) (string, error) { +func executeGetBadJSON(_ string) (string, error) { return "Junk", nil } diff --git a/vault/keyringprovider.go b/vault/keyringprovider.go index 046c3c764..e9ea2ac84 100644 --- a/vault/keyringprovider.go +++ b/vault/keyringprovider.go @@ -13,7 +13,7 @@ type KeyringProvider struct { CredentialsName string } -func (p *KeyringProvider) Retrieve(ctx context.Context) (aws.Credentials, error) { +func (p *KeyringProvider) Retrieve(_ context.Context) (aws.Credentials, error) { log.Printf("Looking up keyring for '%s'", p.CredentialsName) return p.Keyring.Get(p.CredentialsName) }