Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduled testing does not specify test version #12

Open
aidanheerdegen opened this issue Apr 8, 2024 · 6 comments
Open

Scheduled testing does not specify test version #12

aidanheerdegen opened this issue Apr 8, 2024 · 6 comments

Comments

@aidanheerdegen
Copy link
Member

This failure of the scheduled testing

ACCESS-NRI/access-om2-configs#41

highlights that the scheduled testing doesn't define a version of the tests to run. This makes it fragile to changes in the test infrastructure, and so makes it more difficult to change the tests as they could potentially affect many repro tests of older configurations.

Related issues: ACCESS-NRI/access-om2-configs#41

@aidanheerdegen
Copy link
Member Author

Ping @CodeGat

@CodeGat CodeGat self-assigned this Apr 9, 2024
@CodeGat
Copy link
Collaborator

CodeGat commented Apr 11, 2024

For this feature, I was thinking about just adding a new field to the released-configs.json where we could specify a commit-ish object that points to the tests.
Would just a commit hash be good enough to add to that file, or do we want to start versioning tests via tags in this repository as well? We do kinda demarcate the configs by releases now (and tags) so it might not be as much of an issue. But if we start bundling tests into packages properly we might not want to start tagging versions of tests...

@aidanheerdegen
Copy link
Member Author

Heh. Should have read this comment before I made this one:

ACCESS-NRI/reproducibility#26 (comment)

Yes I am wondering how this will work with packaged tests.

@CodeGat
Copy link
Collaborator

CodeGat commented Apr 11, 2024

It might need a small amount of rejigging, but we will still need something very similar to this when the tests are packaged up, anyway

@CodeGat
Copy link
Collaborator

CodeGat commented Apr 12, 2024

Closed the linked PRs because it was a bit of a half-measure towards the test packaging stuff

@aidanheerdegen
Copy link
Member Author

As discussed IRL, but wanted to make a note, the tests version would need to be defined for each tag. It could just be main (or some default pointing to latest when they're packaged), but it would mean we have the option of pinning to a version if tests start failing because they've been updated, but the version of the model is inconsistent with the updated tests.

It could (will) end up creating a support burden to have to update lots of historical configurations to be consistent with updated tests.

@CodeGat CodeGat removed their assignment Apr 16, 2024
@aidanheerdegen aidanheerdegen transferred this issue from ACCESS-NRI/access-om2-configs May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants