You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There seen to be some subtle differences between iris cubes and our DummyCube which would cause the test_fix_level_coord_... tests to fail if we were using real iris cubes.
The cube.coord() method uses the current name for a DimCoord as its argument, where the "current name" comes from either the DimCoord's standard_name, long_name, or var_name, with the following order of priority: standard_name > long_name > var_name.
This means that if a DimCoord only has a var_name attribute, changing the var_name forces us to also change the argument in cube.coord(...) used to access it:
A made up example after modifying a loaded cube's coordinate names:
There seen to be some subtle differences between iris cubes and our
DummyCube
which would cause thetest_fix_level_coord_...
tests to fail if we were using real iris cubes.The
cube.coord()
method uses the current name for aDimCoord
as its argument, where the "current name" comes from either theDimCoord
'sstandard_name
,long_name
, orvar_name
, with the following order of priority:standard_name
>long_name
>var_name
.This means that if a
DimCoord
only has avar_name
attribute, changing thevar_name
forces us to also change the argument incube.coord(...)
used to access it:A made up example after modifying a loaded cube's coordinate names:
In these tests however, we're changing the coordinate's
var_names
but not thecube.coord(...)
arguments used to access them.Given that the tests are working and it's a fairly subtly difference, should we defer this to a separate issue?Originally posted by @blimlim in #113 (comment)
The text was updated successfully, but these errors were encountered: