-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor coord mocks when #63/lat long fixes is merged #69
Comments
From exploratory work on branch Before: um2nc-standalone/test/test_um2netcdf.py Lines 73 to 94 in 120dc47
After: um2nc-standalone/test/test_um2netcdf.py Lines 73 to 78 in 43a541e
|
This was referenced Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When #63 is merged, I'll refactor the
test_process_...()
test setup to remove thecoord
mock & ensure the prod code is called.Removing the
fix_level_coord()
&cubewrite()
mocks can be handled in separate PRs (working on a model of gradually improving tests asum2nc
is improved).Originally posted by @truth-quark in #58 (comment)
To clarify tasks:
Replace buggy implementation with
DummyCube
with no coord attrs:um2nc-standalone/test/test_um2netcdf.py
Lines 73 to 79 in 120dc47
Remove these mocks & the tests should pass:
um2nc-standalone/test/test_um2netcdf.py
Line 160 in 120dc47
The text was updated successfully, but these errors were encountered: