Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Date Argument to bullet_chart_vline Function #41

Open
brichard1638 opened this issue Jul 4, 2023 · 0 comments
Open

Add Date Argument to bullet_chart_vline Function #41

brichard1638 opened this issue Jul 4, 2023 · 0 comments

Comments

@brichard1638
Copy link

Given that the Bullet Chart generated by the bullet_chart_vline function provides a critical data point in the form of a vertical line indicating "Today," it would seem that adding a binary argument to the function indicating whether or not a date was added to the plot as the today value would be an increased value proposition to this function.

In its current form, it is not cleat what "Today" is by reference in the plot. Adding the date the plot was generated would complete the context provided by the plot's comparative analysis between "Today" and last year.

A simple binary argument could be added to allow the user to determine whether Today was added or not to the plot. If a Today date is added, it is recommended that the date be centered at the top of the plot relative to the vertical Today line.

Additional options could be added in another date-based argument including date formatting and whether or not the time was added. It is to be assumed that some bullet plots of this nature may be extremely date and time sensitive.

Consequently, it is suggested that this version of the Bullet Plot is incomplete without defining what "Today" is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant