Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translation in calibration flagging #38

Open
nicholebarry opened this issue Nov 14, 2023 · 1 comment
Open

Missing translation in calibration flagging #38

nicholebarry opened this issue Nov 14, 2023 · 1 comment
Assignees

Comments

@nicholebarry
Copy link
Collaborator

Looks like the last little bit of vis_calibration_flag.pro did not get translated to the python version, specifically:

IF Keyword_Set(no_frequency_flagging) THEN freq_use[*]=1
IF ~Keyword_Set(no_calibration_frequency_flagging) THEN obs_info.freq_use=freq_use

no_frequency_flagging is a common thing to set, it seems

@SkyWa7ch3r
Copy link
Collaborator

Looks like I've missed that no_frequency_flagging and it's used in a few functions, thankfully almost all those functions already import pyfhd_config so I should be able to add it as an option to the flagging group pretty easily. But I'll do it as a positive option i.e. flag_frequencies to avoid any double negatives which are confusing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants