You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When I try to import libafl_libfuzzer_runtime into Chromium, our tooling complains that the crate contents downloaded from crates.io do not contain license files. Would it be possible to include the license files please?
I think that libafl_libfuzzer_runtime/Cargo.toml symlinks to libafl_libfuzzer/Cargo.toml and that this file lists a restricted allowlist of files to include when publishing to crates.io. This file list probably has to be expanded to also cover LICENSE-MIT and LICENSE-APACHE. I assume that the Cargo.toml symlink may also be used in other places - we may need to add more LICENSE-APACHE / LICENSE-MIT symlinks if this is the case.
PS. LICENSE-APACHE says "You must give any other recipients of the Work or Derivative Works a copy of this License". LICENSE-MIT says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.".
The text was updated successfully, but these errors were encountered:
anforowicz
changed the title
LICENSE-MIT nor LICENSE-APACHE files are published to https://crates.io/crates/libafl_libfuzzer_runtime/0.0.0LICENSE-MIT and LICENSE-APACHE should be published to crates.io/crates/libafl_libfuzzer_runtime
Jan 24, 2025
Symlinks can be added from libafl_libfuzzer_runtime/LICENSE-APACHE to ../LICENSE-APACHE (same for LICENSE-MIT). This is quite similar to what other nested crates are doing - e.g. see: rust-lang/rustc-demangle#73
OK I can create a link
I think that libafl_libfuzzer_runtime/Cargo.toml symlinks to libafl_libfuzzer/Cargo.toml and that this file lists a restricted allowlist of files to include when publishing to crates.io. This file list probably has to be expanded to also cover LICENSE-MIT and LICENSE-APACHE. I assume that the Cargo.toml symlink may also be used in other places - we may need to add more LICENSE-APACHE / LICENSE-MIT symlinks if this is the case.
This file has dependencies pointing to libafl, libafl_bolts, and libafl_targets.
Will it be enough if I put a symlink for these three?
When I try to import
libafl_libfuzzer_runtime
into Chromium, our tooling complains that the crate contents downloaded from crates.io do not contain license files. Would it be possible to include the license files please?I think that:
libafl_libfuzzer_runtime/LICENSE-APACHE
to../LICENSE-APACHE
(same forLICENSE-MIT
). This is quite similar to what other nested crates are doing - e.g. see: Add license files into the capi crate tarball rust-lang/rustc-demangle#73libafl_libfuzzer_runtime/Cargo.toml
symlinks tolibafl_libfuzzer/Cargo.toml
and that this file lists a restricted allowlist of files toinclude
when publishing to crates.io. This file list probably has to be expanded to also coverLICENSE-MIT
andLICENSE-APACHE
. I assume that theCargo.toml
symlink may also be used in other places - we may need to add moreLICENSE-APACHE
/LICENSE-MIT
symlinks if this is the case.PS.
LICENSE-APACHE
says "You must give any other recipients of the Work or Derivative Works a copy of this License".LICENSE-MIT
says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."./cc @adetaylor
The text was updated successfully, but these errors were encountered: