Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge DB initialization scripts #251

Open
stefan-k opened this issue Apr 3, 2023 · 2 comments
Open

Merge DB initialization scripts #251

stefan-k opened this issue Apr 3, 2023 · 2 comments
Assignees

Comments

@stefan-k
Copy link
Contributor

stefan-k commented Apr 3, 2023

There are currently two scripts which initialize the necessary DBs: init_db.sh and init_slurm_collector_sqlite.sh. Maybe think about merging the two and update the documentation accordingly.

@QuantumDancer
Copy link
Contributor

Not sure if this makes sense, as we might use only one or the other script in some cases. For example, for integration tests such as the one for the priority plugin:

SKIP_DOCKER=true POSTGRES_DB=$DB_NAME ./scripts/init_db.sh

@stefan-k
Copy link
Contributor Author

stefan-k commented Aug 9, 2023

I was thinking about flags with which one can choose what the script should do. AFAIR there is code duplication in the scripts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants