Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferred mechanism for command line overrides #17

Closed
KiranEiden opened this issue Jun 27, 2018 · 0 comments
Closed

Preferred mechanism for command line overrides #17

KiranEiden opened this issue Jun 27, 2018 · 0 comments

Comments

@KiranEiden
Copy link
Contributor

Currently the command line options --tolerance and --check_performance (addressing issue #5 and issue #15) will override any values set in the configuration files if supplied. Would the option of a "soft" override, where those settings (tolerance and performance threshold/runs to average) are only overridden for individual tests which do not have a tolerance setting or do not already check performance, be a useful addition?

If so, what would be the preferred implementation? One option is to introduce additional command line flags; another is to treat a negative number for a given setting as a soft override for that field.

ax3l added a commit to ax3l/regression_testing that referenced this issue Oct 26, 2021
Fix Bug to Build AMReX Tool particle_compare
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant