Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XsectionDisplay Updates #861

Closed
AdamTheisen opened this issue Oct 11, 2024 · 5 comments
Closed

XsectionDisplay Updates #861

AdamTheisen opened this issue Oct 11, 2024 · 5 comments
Assignees

Comments

@AdamTheisen
Copy link
Collaborator

The XSectionDisplay codes don't quite follow the same format as some of the other plotting functions. The main issue is the dsname is the first variable. We should update to follow similar formats as the other plotting code.

    def plot_xsection_map(
        self, dsname, varname, subplot_index=(0,), coastlines=True, background=False, **kwargs
    ):  
@zssherman
Copy link
Collaborator

Makes sense to me!

@zssherman
Copy link
Collaborator

zssherman commented Oct 11, 2024

@AdamTheisen I noticed we are calling fields differently as well. We either use: 'data_field', 'varname', and 'field'. Which would we want? We should have it the same across.

@AdamTheisen AdamTheisen self-assigned this Oct 11, 2024
@AdamTheisen
Copy link
Collaborator Author

Can we open this to a poll? I would say field is the easiest. I'm already working on some updates to xsectiondisplay so I can handle getting this in.

@zssherman
Copy link
Collaborator

Yeah I think field would be fine. We could open a poll as well.

@AdamTheisen
Copy link
Collaborator Author

We resolved this with merging in of #862

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants