Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arm_biquad_cascade_df2T_f32 Neon version is not working (and scalar version is enabled in library) #231

Open
mw-kakkala opened this issue Jan 16, 2025 · 2 comments
Labels
bug Something isn't working

Comments

@mw-kakkala
Copy link

mw-kakkala commented Jan 16, 2025

 We are utilizing CMSIS-DSP version 1.14.3 to produce optimized code through the MATLAB workflow, targeting ARM Cortex-A
 family devices with CRL.  We've enabled the 'ARM_MATH_NEON' flag to leverage the NEON SIMD instruction set. 
 However, after generating the optimized code using this flag, the results do not align with the simulation outcomes. 
 Conversely, when we use the default C implementation of the 'arm_biquad_cascade_df2T_f32()' function from CMSIS-DSP,
  the results match the simulation. Please let me know if there are any updates regarding this issue.

Regards,
Kishor

@christophe0606
Copy link
Contributor

@mw-kakkala Do you have a reproducer you can share ? Like some filter coefficients and a sample input ?

Note that in Neon mode, arm_biquad_cascade_df2T_init_f32 do not take the filter coefficients directly. You need to use arm_biquad_cascade_df2T_compute_coefs_f32 to generate a new array that can be passed to the init function

It is detailed in the documentation for arm_biquad_cascade_df2T_init_f32

@christophe0606 christophe0606 added the review Under review label Jan 16, 2025
@christophe0606
Copy link
Contributor

I see latest version of CMSIS-DSP have disabled the Neon version of this kernel. So, it looks like it indeed has issues.

@christophe0606 christophe0606 added bug Something isn't working and removed review Under review labels Jan 23, 2025
@christophe0606 christophe0606 changed the title When the "ARM_MATH_NEON" flag is set, the results from the "arm_biquad_cascade_df2T_f32" function do not match with the MATLAB simulation outcomes. However, the results from the optimized C code do match the simulation results. arm_biquad_cascade_df2T_f32 Neon version is not working (and scalar version is enabled in library) Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants