Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create solution from Blank_project template adds wrong board vendor #132

Open
ReinhardKeil opened this issue Nov 27, 2024 · 11 comments
Open
Assignees
Labels
bug Something isn't working web This issue depends on web APIs and Services

Comments

@ReinhardKeil
Copy link
Collaborator

ReinhardKeil commented Nov 27, 2024

Use in Create New solution with "ABOV::StarterKit-A31G112CL:V1.1"

Details see Open-CMSIS-Pack/devtools#1671 - 2nd comment

@ReinhardKeil ReinhardKeil added the bug Something isn't working label Nov 27, 2024
@thorstendb-ARM
Copy link
Collaborator

thorstendb-ARM commented Nov 27, 2024

Vendor names are translated by Solar for the webpage. Solvable when the gRPC interface is provided by the web team.

@JonatanAntoni
Copy link
Member

Solar web service provides the "wrong" board vendor name. While in the PDSC file ABOV uses just ABOV as pack and board vendor names, we forced them to use ABOV Semiconductors as device vendor. Solar uses the device vendor enum in all places. This problem is expected to be solved when getting all data from Core Tools directly, as Thorsten indicated.

@jkrech jkrech moved this to Backlog in CMSIS Solution Extension Dec 2, 2024
@jkrech jkrech added the web This issue depends on web APIs and Services label Dec 5, 2024
@JonatanAntoni
Copy link
Member

Depends on #147

@ReinhardKeil
Copy link
Collaborator Author

ReinhardKeil commented Jan 14, 2025

I suggest we implement for now (until web interface is fixed):

  • Templates and Reference Apps are only shown from local installed packs.
  • Examples are shown from both web and local packs.

@JonatanAntoni
Copy link
Member

@ReinhardKeil, do you want the blank templates to be removed from the list for devices from web packs?

@ReinhardKeil
Copy link
Collaborator Author

When a device comes from a web service, there should be only examples shown. No templates, even no built-in templates should be listed.

@JonatanAntoni JonatanAntoni moved this from Backlog to In progress in CMSIS Solution Extension Jan 21, 2025
@JonatanAntoni
Copy link
Member

@ReinhardKeil, I think the underlaying problem has already been "solved" by adding boards/devices only by name omitting the vendor's name. This is expected to work unless there is a name clash on board/device names between different vendors and both packs are selected for the solution. Such a clash is very unlikely to happen. Hence, I'd leave it as is and keep the blank templates also for web results.

@JonatanAntoni JonatanAntoni moved this from In progress to In review in CMSIS Solution Extension Jan 21, 2025
@DavidLesnjak
Copy link

@JonatanAntoni, adding a board without vendor name has a side effect on a cbridge. If a board doesn't have board vendor specified, cbridge can't launch STM32CubeMX to be preconfigured for a board.

@JonatanAntoni
Copy link
Member

@JonatanAntoni, adding a board without vendor name has a side effect on a cbridge. If a board doesn't have board vendor specified, cbridge can't launch STM32CubeMX to be preconfigured for a board.

Outch. That means our current implementation is broken for that scenario/use case?
Can we fix that in cbridge instead? Whats the order of command we are running? First cbuild setup --packs and then cbridge? I.e., can we assume all packs already installed when running cbridge?

@DavidLesnjak
Copy link

There is no "clean" way to solve this in cbridge. Cbridge uses cbuild-gen-idx.yml as an input parameter. I didn't analyze the order of commands., but I assume that cbuild-gen-idx.yml is generated when generator is launched by the user and at that point all packs are already installed.
@brondani, could you maybe help with this? Is it possible that board vendor is add to the cbuild-gen-idx.yml although is missing in csolution.yml?

@brondani
Copy link
Collaborator

@brondani, could you maybe help with this? Is it possible that board vendor is add to the cbuild-gen-idx.yml although is missing in csolution.yml?

Yes this will be fixed, tracked in Open-CMSIS-Pack/devtools#1930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working web This issue depends on web APIs and Services
Projects
Status: In review
Development

No branches or pull requests

6 participants