Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrepair Math-78 by JKali #103

Open
martinezmatias opened this issue Sep 24, 2021 · 5 comments
Open

Unrepair Math-78 by JKali #103

martinezmatias opened this issue Sep 24, 2021 · 5 comments

Comments

@martinezmatias
Copy link
Collaborator

jGenProg arrives to repair with Gzoltar, but not with Flacoco (which does not fail)
Logs for the two executions, first gzoltar, then Flacoco

https://github.com/martinezmatias/astor/runs/3676644911?check_suite_focus=true#step:8:3314
@andre15silva
Copy link
Member

This is not an issue with flacoco.

The location that is patched through GZoltar is the following:

location= org.apache.commons.math.ode.events.EventState
line= 175
lineSuspiciousness= 0.107

Flacoco identifies this line, with the same suspiciousness value:
org.apache.commons.math.ode.events.EventState@-@175,0.10660035817780521

The difference is in the "priority". For GZoltar, this line is the 47th, whereas for Flacoco it is the 60th (cropped out the lines that appear after):

GZoltar:

[22383] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 37, susp 1.0
[22383] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 313, susp 1.0
[22384] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 319, susp 1.0
[22384] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 102, susp 0.5773502691896258
[22384] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 103, susp 0.5773502691896258
[22385] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 115, susp 0.5773502691896258
[22392] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.MathRuntimeException l: 128, susp 0.5773502691896258
[22392] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 178, susp 0.5773502691896258
[22392] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 181, susp 0.5773502691896258
[22392] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 170, susp 0.5
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 173, susp 0.5
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 282, susp 0.30151134457776363
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 283, susp 0.30151134457776363
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.sampling.DummyStepInterpolator l: 99, susp 0.2182178902359924
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.sampling.DummyStepInterpolator l: 100, susp 0.2182178902359924
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 267, susp 0.17149858514250882
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 268, susp 0.17149858514250882
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 269, susp 0.17149858514250882
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 270, susp 0.17149858514250882
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.analysis.solvers.BrentSolver l: 296, susp 0.16222142113076254
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 219, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 224, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 226, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 227, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 236, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 237, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 271, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 290, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 291, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 292, susp 0.1091089451179962
[22393] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 206, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 207, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 201, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 203, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 215, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 216, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 217, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 218, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 42, susp 0.10846522890932808
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 151, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 152, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 153, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 154, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 172, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 173, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 174, susp 0.10660035817780521
[22394] INFO GZoltarFaultLocalization - Suspicious:  line org.apache.commons.math.ode.events.EventState l: 175, susp 0.10660035817780521

Flacoco:

org.apache.commons.math.MathRuntimeException$4@-@313,1.0
org.apache.commons.math.MathRuntimeException$4@-@319,1.0
org.apache.commons.math.MathRuntimeException@-@102,0.5773502691896258
org.apache.commons.math.MathRuntimeException@-@109,0.5773502691896258
org.apache.commons.math.MathRuntimeException@-@115,0.5773502691896258
org.apache.commons.math.MathRuntimeException@-@128,0.5773502691896258
org.apache.commons.math.analysis.solvers.BrentSolver@-@178,0.5773502691896258
org.apache.commons.math.analysis.solvers.BrentSolver@-@181,0.5773502691896258
org.apache.commons.math.analysis.solvers.BrentSolver@-@170,0.5
org.apache.commons.math.analysis.solvers.BrentSolver@-@173,0.5
org.apache.commons.math.analysis.solvers.BrentSolver@-@282,0.30151134457776363
org.apache.commons.math.analysis.solvers.BrentSolver@-@283,0.30151134457776363
org.apache.commons.math.ode.sampling.DummyStepInterpolator@-@99,0.2182178902359924
org.apache.commons.math.ode.sampling.DummyStepInterpolator@-@100,0.2182178902359924
org.apache.commons.math.ode.sampling.DummyStepInterpolator@-@66,0.20412414523193154
org.apache.commons.math.ode.sampling.DummyStepInterpolator@-@67,0.20412414523193154
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@107,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@109,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@110,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@111,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@112,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@114,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@115,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@116,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@118,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@119,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@120,0.17677669529663687
org.apache.commons.math.ode.sampling.AbstractStepInterpolator@-@122,0.17677669529663687
org.apache.commons.math.analysis.solvers.BrentSolver@-@267,0.17149858514250882
org.apache.commons.math.analysis.solvers.BrentSolver@-@268,0.17149858514250882
org.apache.commons.math.analysis.solvers.BrentSolver@-@269,0.17149858514250882
org.apache.commons.math.analysis.solvers.BrentSolver@-@270,0.17149858514250882
org.apache.commons.math.analysis.solvers.BrentSolver@-@296,0.16222142113076254
org.apache.commons.math.ode.events.EventState@-@218,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@219,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@224,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@226,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@227,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@236,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@237,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@271,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@290,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@291,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@292,0.1091089451179962
org.apache.commons.math.ode.events.EventState@-@201,0.10846522890932808
org.apache.commons.math.ode.events.EventState@-@203,0.10846522890932808
org.apache.commons.math.ode.events.EventState$1@-@203,0.10846522890932808
org.apache.commons.math.ode.events.EventState$1@-@206,0.10846522890932808
org.apache.commons.math.ode.events.EventState$1@-@207,0.10846522890932808
org.apache.commons.math.ode.events.EventState@-@215,0.10846522890932808
org.apache.commons.math.ode.events.EventState@-@216,0.10846522890932808
org.apache.commons.math.ode.events.EventState@-@217,0.10846522890932808
org.apache.commons.math.ode.events.EventState@-@151,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@152,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@153,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@154,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@172,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@173,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@174,0.10660035817780521
org.apache.commons.math.ode.events.EventState@-@175,0.10660035817780521

@monperrus monperrus mentioned this issue Oct 4, 2021
Closed
@martinezmatias martinezmatias mentioned this issue Oct 11, 2021
Open
@martinezmatias
Copy link
Collaborator Author

There is a flaky test in that program (https://github.com/martinezmatias/astor/runs/3851808288?check_suite_focus=true#step:8:77). That could be the reason. I will exclude that test from the analysis.

@andre15silva
Copy link
Member

Did that return any new information?

I thought the issue was with patch synthesis on this one, no?

@martinezmatias
Copy link
Collaborator Author

martinezmatias commented Oct 20, 2021 •
edited
Loading

Math-78 is now working with JGenProg. I ignore a (flaky?) test case that is failing and it should not (org.apache.commons.math.random.RandomAdaptorTest)

Now I am inspecting why JKali does not repair it: the patch to be found is here: https://github.com/Spirals-Team/defects4j-repair/blob/master/results/2015-august/Math/78/Kali/stdout.log#L29

https://github.com/martinezmatias/astor/runs/3949793045?check_suite_focus=true#step:8:139

@martinezmatias martinezmatias changed the title Unrepair Math-78 Unrepair Math-78 by JKali Oct 20, 2021
@monperrus
Copy link
Collaborator

monperrus commented Oct 20, 2021 via email

@martinezmatias martinezmatias mentioned this issue Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@monperrus @martinezmatias @andre15silva