Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unreachable Code in model_pipeline #380

Open
mauvais2 opened this issue Nov 6, 2024 · 0 comments
Open

Remove Unreachable Code in model_pipeline #380

mauvais2 opened this issue Nov 6, 2024 · 0 comments

Comments

@mauvais2
Copy link
Collaborator

mauvais2 commented Nov 6, 2024

In model_pipeline.get_metrics(), there are two returns inside the if statement:

https://github.com/ATOMScience-org/AMPL/blob/master/atomsci/ddm/pipeline/model_pipeline.py#L449

The code may not get used. Will delete the first return and test when the model tracker is running.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant