From 887791f103e852638aa2215b703a4110e9ed07aa Mon Sep 17 00:00:00 2001 From: AWSHurneyt Date: Tue, 23 Jan 2024 19:13:34 -0800 Subject: [PATCH] Removed default admin credentials. (#837) Signed-off-by: AWSHurneyt (cherry picked from commit 7f38be12b007a8018d25a956a062cb7354a4ff46) Signed-off-by: AWSHurneyt --- .github/workflows/security-notifications-test-workflow.yml | 6 +++--- DEVELOPER_GUIDE.md | 4 ++-- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/security-notifications-test-workflow.yml b/.github/workflows/security-notifications-test-workflow.yml index 184dc60f..a36b07ca 100644 --- a/.github/workflows/security-notifications-test-workflow.yml +++ b/.github/workflows/security-notifications-test-workflow.yml @@ -73,9 +73,9 @@ jobs: if: env.imagePresent == 'true' run: | cd .. - docker run -p 9200:9200 -d -p 9600:9600 -e "discovery.type=single-node" opensearch-notifications:test + container_id=`docker run -p 9200:9200 -d -p 9600:9600 -e "OPENSEARCH_INITIAL_ADMIN_PASSWORD=myStrongPassword123!" -e "discovery.type=single-node" opensearch-notifications:test` sleep 120 - + echo `docker logs $container_id` - name: Run Notification Test for security enabled test cases if: env.imagePresent == 'true' run: | @@ -87,7 +87,7 @@ jobs: then echo "Security plugin is available" cd notifications - ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=docker-cluster -Dhttps=true -Duser=admin -Dpassword=admin + ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=docker-cluster -Dhttps=true -Duser=admin -Dpassword=myStrongPassword123! else echo "Security plugin is NOT available skipping this run as tests without security have already been run" exit 1 diff --git a/DEVELOPER_GUIDE.md b/DEVELOPER_GUIDE.md index ff208a9b..83a1c0b5 100644 --- a/DEVELOPER_GUIDE.md +++ b/DEVELOPER_GUIDE.md @@ -64,8 +64,8 @@ When launching a cluster using above commands, logs are placed in `notifications 1. Setup a local OpenSearch cluster with security plugin. - `./gradlew build` -- `./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch-integrationtest -Dhttps=true -Duser=admin -Dpassword=admin` -- `./gradlew integTestRunner -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch-integrationtest -Dhttps=true -Duser=admin -Dpassword=admin --tests ""` +- `./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch-integrationtest -Dhttps=true -Duser=admin -Dpassword=` +- `./gradlew integTestRunner -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch-integrationtest -Dhttps=true -Duser=admin -Dpassword= --tests ""` ### Debugging