Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stairs have different block ID based on direction #180

Open
Charnuz opened this issue Oct 6, 2019 · 3 comments
Open

Stairs have different block ID based on direction #180

Charnuz opened this issue Oct 6, 2019 · 3 comments
Labels
1.12.2 Breaking This change / fix will break some compatibility bug Something isn't working confirmed The bug is confirmed

Comments

@Charnuz
Copy link

Charnuz commented Oct 6, 2019

Minecraft: 1.12.2
Forge: 14.23.5.2838
UB: 1.3.7

Since stairs have a different block ID for each direction, for Red Granite there is:

undergroundbiomes:igneous_brick_stairs_east:0
undergroundbiomes:igneous_brick_stairs_west:0
undergroundbiomes:igneous_brick_stairs_north:0
undergroundbiomes:igneous_brick_stairs_south:0

A side effect of this is mods that generate structures and use the stairs (like Roguelike Dungeons) cannot automatically rotate the stairs to the needed direction.

w
e
n
s

@Aang23 Aang23 pinned this issue Oct 6, 2019
@Aang23
Copy link
Owner

Aang23 commented Oct 6, 2019

I don't know why kyeiti did it like that.
I'm gonna make those tile entities, but that'll be a breaking release!

@Aang23 Aang23 added 1.12.2 Breaking This change / fix will break some compatibility bug Something isn't working confirmed The bug is confirmed labels Oct 6, 2019
@Juuxel
Copy link

Juuxel commented Oct 6, 2019

It's probably because of the block state limit to 16 (I think 1.12 still had that?). Instead of TEs you could also split up the different stone types to different stair block IDs (red_granite_stairs and so on).

@Aang23
Copy link
Owner

Aang23 commented Oct 6, 2019

@Juuxel That would work and that's how it works in 1.14+. Though it'll be way easier to use data tiles than rewriting that much.
If I were to do that I would probably rewrite a major chunk of the mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.12.2 Breaking This change / fix will break some compatibility bug Something isn't working confirmed The bug is confirmed
Projects
None yet
Development

No branches or pull requests

3 participants