SonarCloud Analysis broken by recent update to sonar-scanner

[jfpanisset]

SonarCloud analysis for Imath last succeeded in uploading results on 2024-01-13:

https://sonarcloud.io/project/overview?id=AcademySoftwareFoundation_Imath

The issue seems to be caused by the deprecation of the sonar.login parameter:

https://github.com/AcademySoftwareFoundation/Imath/actions/runs/7945143614/job/21691431831

00:27:48.413 WARN: The property 'sonar.login' is deprecated and will be removed in the future. Please use the 'sonar.token' property instead when passing a token.

The documentation as well as OpenImageIO's analysis workflow indicates that it isn't necessary to set the token on the CLI, it should be sufficient to set the SONAR_TOKEN environment variable which analysis_workflow.yml already does.

Removing -Dsonar.login=$SONAR_TOKEN from the sonar-scanner command line should hopefully be sufficient to restore the functionality of uploading results back to the SonarCloud site.

A similar issue exists for OpenEXR, issue 1646.