You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While helping Masuo get the hex tiling PR working in MSL, I spent a long time being confused....
Commenting out #include lines does not stop them from being included.
//#include "mx_math.glsl"
The mx_math.glsl file was still being included, causing compile errors.
In this case we don't actually need to include this file, but in general we need shader generation to be robust, as its a bit of a blackbox for shader developers.
The text was updated successfully, but these errors were encountered:
jstone-lucasfilm
changed the title
#include handling broken in Shader Generation
Commenting of #include directives is not respected by shader generation
Oct 30, 2024
While helping Masuo get the hex tiling PR working in MSL, I spent a long time being confused....
Commenting out
#include
lines does not stop them from being included.The
mx_math.glsl
file was still being included, causing compile errors.In this case we don't actually need to include this file, but in general we need shader generation to be robust, as its a bit of a blackbox for shader developers.
The text was updated successfully, but these errors were encountered: