Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the view menu in the ociodisplay app #2057

Open
doug-walker opened this issue Sep 24, 2024 · 5 comments
Open

Fix the view menu in the ociodisplay app #2057

doug-walker opened this issue Sep 24, 2024 · 5 comments
Assignees
Labels
Bug Unwanted or incorrect behavior in currently available functionality. good first issue Standard label for new developers to locate good issues to tackle to learn about OCIO development. help wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources.

Comments

@doug-walker
Copy link
Collaborator

This would be a great first issue for someone!

Under the src/apps directory, OCIO comes with a few applications that allow people to test out various aspects of the software. One of these applications is "ociodisplay" which allows the user display an image in a window with OCIO processing applied.

In an OCIO config, there are a series of "displays" and each display has a series of "views". In general, each display may have a different set of views. For example, the views associated to an SDR display is usually different than for an HDR display.

Unfortunately, the primitive menu system in ociodisplay assumes that each display has exactly the same views. To see this, run the app with the -v option so it prints the actual display and view being used to the shell (they will be different from what you see in the menus). Use the control-click menu to select various options from the "Device" menu (these are the displays), and then select options from the "Transform" menu (these are the views). (While you're at it, you could rename those menus to be "Display" and "Views".)

The built-in Studio config is an example config that shows the problem. Set the OCIO environment variable to "ocio://studio-config-latest" before launching ociodisplay to use that config.

For test images, you could use one of the OpenEXR ACES test images from [here](https://www.dropbox.com/scl/fo/zbrp6siai5r9wgasdlmle/ABYNKw5mO_aYdDn3m59c6cs/ACES?dl=0&rlkey=41zj6by2t39ckzt0caydb7s91&subfolder_nav_tracking=1).

@doug-walker doug-walker added good first issue Standard label for new developers to locate good issues to tackle to learn about OCIO development. help wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources. Bug Unwanted or incorrect behavior in currently available functionality. labels Sep 24, 2024
@hannahmkrasnick
Copy link

I would love to tackle this issue for Dev Days!

@doug-walker
Copy link
Collaborator Author

Thank you Hannah, I've assigned this to you!

@carolalynn
Copy link
Collaborator

Hi @hannahmkrasnick - just wanted to do a quick follow-up and see if you are still planning on tackling this issue? We'd love to have you participate - but either way, just let us know! :)

@hannahmkrasnick
Copy link

Hey @carolalynn ! I am, I will put up a PR this morning :) I don't think I have the right permissions yet but I'll throw it up anyway!

@carolalynn
Copy link
Collaborator

Sounds great, @hannahmkrasnick - feel free to reach out on our slack if you need anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Unwanted or incorrect behavior in currently available functionality. good first issue Standard label for new developers to locate good issues to tackle to learn about OCIO development. help wanted Issues that the TSC has decided are worth implementing, but don't currently have the dev resources.
Projects
None yet
Development

No branches or pull requests

3 participants