Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coat and Fuzz parameter order inconsistent between specification and reference implementation #223

Open
JGamache-autodesk opened this issue Jul 8, 2024 · 2 comments

Comments

@JGamache-autodesk
Copy link

Clearly a very minor detail, but the reference implementation has Fuzz before Coat while the specification has Coat before Fuzz in the parameter reference.

@JGamache-autodesk
Copy link
Author

The Emission and Thin Film sections are also swapped between spec and reference implementation.

@portsmouth
Copy link
Contributor

I think coat before fuzz makes more sense for OpenPBR, since we generally order the parameters from the base upwards.

Having emission before thin-film (and thin-film after fuzz) doesn't seem particularly logical though. Arguably the emission should be just before the coat (since the coat tints the emission):

We put emission below the coating so that emitted light will be tinted due to the absorption in the coat and fuzz layers.

And the thin-film should be just before the emission, since it lies above the base, but does not tint the emission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants