Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuites that build subprojects ignore the options top level cmake was invoked with #1632

Open
AlexMWells opened this issue Dec 22, 2022 · 0 comments

Comments

@AlexMWells
Copy link
Contributor

Problem

Testsuites that build subprojects ignore the options top level cmake was invoked with.

Actual behavior:

Example:
https://github.com/AcademySoftwareFoundation/OpenShadingLanguage/blob/main/testsuite/example-deformer/run.py
currently ignores any cmake options this build was invoked with, ie:
MYCC=...
MYCXX=...
LLVM_DIRECTORY=...
ILMBASE_ROOT=...
OPENEXR_ROOT=...
BOOST_ROOT=...
OpenImageIO_ROOT=...
pugixml_ROOT=...
pybind11_ROOT=...
partio_ROOT=.. \

This can cause build failures from cmake not configuring because it can't find dependency or worse if the wrong version of the dependency is found. Failed builds from API/ABI incompatibilities or undefined behavior could ensue.

Expected behavior:
Any CMAKE options that apply to testsuite subprojects would be propagated through to their cmake invocations

Steps to Reproduce

  1. Remove OIIO from your path or have it point to an older version.
  2. Build using OpenImageIO_ROOT cmake option
  3. build TEST target and see example-deformer fail to build.

Versions

  • OSL branch/version: All
  • OS: Linux
  • C++ compiler: All
  • LLVM version: All
  • OIIO version: All
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant