Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Landscape Entry for PySceneDetect #779

Closed
Breakthrough opened this issue Dec 19, 2023 · 2 comments
Closed

Update Landscape Entry for PySceneDetect #779

Breakthrough opened this issue Dec 19, 2023 · 2 comments
Assignees

Comments

@Breakthrough
Copy link

Changes requested

Hello;

The license for the project PySceneDetect is BSD 3-Clause.

Thanks!

P.S. I appreciate your work and glad you all find the project useful :)

@jmertic
Copy link
Collaborator

jmertic commented Dec 20, 2023

Hi @Breakthrough, thanks for the kind words and for reaching out.

One thing to note is that the Landscape pulls what GitHub says the license is; you can read more about it at https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/licensing-a-repository#detecting-a-license and see the actual project used at https://github.com/licensee/licensee.

Looking at your LICENSE file ( https://github.com/Breakthrough/PySceneDetect/blob/main/LICENSE ), it appears you put both the primary license and the licenses for third-party components in that file. If you'd separate those third-party licenses into a separate file ( such as THIRD-PARTY.md ), that should fix the license detection. Check out how OpenColorIO does this ( https://github.com/AcademySoftwareFoundation/opencolorio ) for an example pattern to follow.

Hopefully this helps!

@Breakthrough
Copy link
Author

Thanks so much for the suggestion, I'll be sure to update that for the next release of PySceneDetect. Appreciate the reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants