Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOONSHOT] Verify that we own numbers purchased through FirstPoint/Endstream #167

Open
uncheckederror opened this issue Mar 11, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request internal Helps an internal customer

Comments

@uncheckederror
Copy link
Collaborator

@uncheckederror If we buy a number from anyone besides FirstPoint/Endstream, it is safe to assume we own it. Otherwise it needs manual verification.

Originally posted by @danry25 in #71 (comment)

To verify that we own a number we'll need a FusionPBX API that we can use to place a call to the number in question and verify that this number is being route to us.

@uncheckederror uncheckederror added enhancement New feature or request internal Helps an internal customer labels Mar 11, 2021
@uncheckederror
Copy link
Collaborator Author

@danry25 is this possible through the new dsip router APIs?

@danry25
Copy link
Collaborator

danry25 commented Jul 22, 2021

Yea, this is possible through the new dsiprouter APIs. I need to get this implemented,

@danry25
Copy link
Collaborator

danry25 commented Oct 8, 2021

I still need to provide you with an API to handle this. Call48 also needs number validation since we generally have to email them to manually assign our numbers ordered via API or their website (despite them automatically billing us for these numbers!).

@danry25
Copy link
Collaborator

danry25 commented Apr 30, 2023

@thefinn93 Could you assist in providing an API to place these test calls, then logic to catch calls from our test number in FusionPBX?

@thefinn93
Copy link

I have added actions originate and cdr-list to the FusionPBX API.

@thefinn93
Copy link

catching the test call and doing something special with it will require a little more BS, working on that now.

@uncheckederror uncheckederror changed the title Verify that we own numbers purchased through FirstPoint/Endstream [MOONSHOT] Verify that we own numbers purchased through FirstPoint/Endstream Aug 12, 2023
@danry25
Copy link
Collaborator

danry25 commented Oct 15, 2023

I can catch the verification call in FusionPBX using Call Block if we use a consistent caller ID, we can create a call to each number in Owned Numbers that is marked Active using Twilio's Make a Call REST API, then we can use the cdr-list endpoint after each 100 test calls to numbers in a given FusionPBX domain to see if the call actually completed.

Other erratta we should handle is if the call is answered (which should never ever happen) the phone number should be flagged for review by our Customer Support team in the daily briefings email and further test calls should cease until support toggles testing a given number back on (perhaps in Owned Numbers in Ops?).

Dan's ToDo
API endpoints I have provided examples for:

  • Twilio's Make a Call REST API
  • Our FusionPBX API cdr-list endpoint
  • Pulling Twilio's call records to see if a call connected (or perhaps this is included in the response? to the REST call?)

Tasks:

  • Block inbound calls from 3603352884 to any number in a FusionPBX instance (pending this FusionPBX.com ticket)
  • Verify 3603352884 as a caller ID on Twilio
  • Disable checking numbers not routed to a FusionPBX instance (need to work with @uncheckederror on a UX for this)

@danry25 danry25 assigned uncheckederror and unassigned danry25 Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal Helps an internal customer
Projects
None yet
Development

No branches or pull requests

3 participants