From 696f46739fdccd6d1e2a7777b74b5b2114e758f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20P=C5=99evr=C3=A1til?= Date: Wed, 1 May 2024 10:38:52 +0200 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9B=20Fix=20LSP=20printers=20devnull?= =?UTF-8?q?=20fd=20kept=20open?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- wake/lsp/lsp_compiler.py | 33 +++++++++++++++++---------------- 1 file changed, 17 insertions(+), 16 deletions(-) diff --git a/wake/lsp/lsp_compiler.py b/wake/lsp/lsp_compiler.py index 064ab987c..deab94fd9 100644 --- a/wake/lsp/lsp_compiler.py +++ b/wake/lsp/lsp_compiler.py @@ -1161,22 +1161,23 @@ async def __run_printers(self) -> None: logging_buffer = [] logging_handler = LspLoggingHandler(logging_buffer) - console = Console(file=open(os.devnull, "w")) - - _, printer_exceptions = run_printers( - all_printers, - self.last_build, - self.last_build_info, - self.__last_graph, - self.__config, - console, - None, - self.__printers_lsp_provider, - verify_paths=False, - capture_exceptions=True, - logging_handler=logging_handler, - extra={"lsp": True}, - ) + with open(os.devnull, "w") as devnull: + console = Console(file=devnull) + + _, printer_exceptions = run_printers( + all_printers, + self.last_build, + self.last_build_info, + self.__last_graph, + self.__config, + console, + None, + self.__printers_lsp_provider, + verify_paths=False, + capture_exceptions=True, + logging_handler=logging_handler, + extra={"lsp": True}, + ) exceptions = {name: repr(e) for name, e in printer_exceptions.items()} for log, log_type in logging_buffer: