Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move string formatting out of ReqRes class #3

Open
ackdom opened this issue Nov 8, 2016 · 1 comment
Open

Move string formatting out of ReqRes class #3

ackdom opened this issue Nov 8, 2016 · 1 comment

Comments

@ackdom
Copy link
Member

ackdom commented Nov 8, 2016

Because of work on ios logging to ElasticSearch I would like to use ReqRes feature to "listen"on Requests and Responses.

I would like to separate "output format" and "logger for output format" out of the ReqRes. I know it brings up some level of additional complexity. But if written correctly it wont affect the original simplicity and intentions of use.

first idea out of the Box is to have Generic Formatter which conforms to logResponse, logRequest/ Error interface... and this formatter has output of T

Formatters will have Logger which accepts T as input and do whatever it wants with it.

if you agree i can start working on it and create pull request.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 20, 2020
@github-actions github-actions bot removed the stale label Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant