From 860e8012738e3698a49f6edb8bc0a23bd06f3a51 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Bj=C3=A4reholt?= Date: Thu, 24 Mar 2022 13:38:43 +0100 Subject: [PATCH] fix: detect .bat and .cmd executables on Windows --- aw_qt/manager.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/aw_qt/manager.py b/aw_qt/manager.py index f29e0ca..db9715a 100644 --- a/aw_qt/manager.py +++ b/aw_qt/manager.py @@ -29,7 +29,11 @@ def is_executable(path: str, filename: str) -> bool: return False # On windows all files ending with .exe are executables if platform.system() == "Windows": - return filename.endswith(".exe") + return ( + filename.endswith(".exe") + or filename.endswith(".bat") + or filename.endswith(".cmd") + ) # On Unix platforms all files having executable permissions are executables # We do not however want to include .desktop files else: # Assumes Unix @@ -63,10 +67,10 @@ def _filename_to_name(filename: str) -> str: def _discover_modules_bundled() -> List["Module"]: - """Use ``_discover_modules_in_directory`` to find all bundled modules """ + """Use ``_discover_modules_in_directory`` to find all bundled modules""" search_paths = [_module_dir, _parent_dir] if platform.system() == "Darwin": - macos_dir = os.path.abspath(os.path.join(_parent_dir, os.pardir, 'MacOS')) + macos_dir = os.path.abspath(os.path.join(_parent_dir, os.pardir, "MacOS")) search_paths.append(macos_dir) logger.info("Searching for bundled modules in: {}".format(search_paths))