From aa8be111d01fa8480b48ddbab228950cda97a60c Mon Sep 17 00:00:00 2001 From: Adam Date: Sun, 23 Jun 2024 11:42:10 -0400 Subject: [PATCH] why is pmd so stupid --- .../net/runelite/client/plugins/banktags/tabs/Layout.java | 4 ++-- .../runelite/client/plugins/banktags/tabs/LayoutManager.java | 4 ++-- .../runelite/client/plugins/banktags/tabs/TabInterface.java | 5 ++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/Layout.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/Layout.java index 5ef98d518aa..f4cab6500e7 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/Layout.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/Layout.java @@ -175,9 +175,9 @@ else if (sidx > tidx) public int count(int itemId) { int c = 0; - for (int i = 0; i < layout.length; ++i) + for (int value : layout) { - if (layout[i] == itemId) + if (value == itemId) { ++c; } diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/LayoutManager.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/LayoutManager.java index bd6d75c6e61..03df4fd1c80 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/LayoutManager.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/LayoutManager.java @@ -140,9 +140,9 @@ void layout(Layout l) for (ItemMatcher matcher : matchers) { - for (int pos = 0; pos < layoutScratch.length; ++pos) + // tagged item id + for (int itemId : layoutScratch) { - int itemId = layoutScratch[pos]; // tagged item id if (itemId == -1 || layoutToBank.containsKey(itemId)) { continue; diff --git a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java index 813605be2ed..9ba8bc502b8 100644 --- a/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java +++ b/runelite-client/src/main/java/net/runelite/client/plugins/banktags/tabs/TabInterface.java @@ -336,13 +336,12 @@ public void onScriptCallbackEvent(ScriptCallbackEvent event) { if (event.getEventName().equals("bankBuildTab")) { - var stack = client.getIntStack(); - var sz = client.getIntStackSize(); - // Use the per-tab view when we want to hide the separators to avoid having to reposition items & // recomputing the scroll height. if (activeTab != null && (tagTabActive || config.removeSeparators() || activeTab.hasLayout())) { + var stack = client.getIntStack(); // NOPMD: UnusedLocalVariable + var sz = client.getIntStackSize(); stack[sz - 1] = 1; // use single tab view mode } }