diff --git a/upstream/hostsresolver.go b/upstream/hostsresolver.go index 5061af270..cfe3921b6 100644 --- a/upstream/hostsresolver.go +++ b/upstream/hostsresolver.go @@ -32,6 +32,7 @@ func NewDefaultHostsResolver(rootFSys fs.FS) (hr *HostsResolver, err error) { return nil, fmt.Errorf("getting default hosts paths: %w", err) } + // The error is always nil here since no readers passed. strg, _ := hostsfile.NewDefaultStorage() for _, filename := range paths { err = parseHostsFile(rootFSys, strg, filename) @@ -74,12 +75,12 @@ func (hr *HostsResolver) LookupNetIP( network string, host string, ) (addrs []netip.Addr, err error) { - var checkIP func(netip.Addr) (ok bool) + var ipMatches func(netip.Addr) (ok bool) switch network { case "ip4": - checkIP = netip.Addr.Is4 + ipMatches = netip.Addr.Is4 case "ip6": - checkIP = netip.Addr.Is6 + ipMatches = netip.Addr.Is6 case "ip": return slices.Clone(hr.strg.ByName(host)), nil default: @@ -87,7 +88,7 @@ func (hr *HostsResolver) LookupNetIP( } for _, n := range hr.strg.ByName(host) { - if checkIP(n) { + if ipMatches(n) { addrs = append(addrs, n) } }