Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable type Not required #241

Open
1 task done
pawan opened this issue Feb 29, 2024 · 1 comment
Open
1 task done

Variable type Not required #241

pawan opened this issue Feb 29, 2024 · 1 comment
Assignees

Comments

@pawan
Copy link
Contributor

pawan commented Feb 29, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Which topic?

https://developer.adobe.com/commerce/php/tutorials/frontend/custom-checkout/add-shipping-carrier/

What's wrong with the content?

In the guide for Add a custom shipping carrier section 3 i.e. https://developer.adobe.com/commerce/php/tutorials/frontend/custom-checkout/add-shipping-carrier/#step-3-create-the-carrier-model at line number 20 and 22, variables $_code and $_isFixed type declaration not required and if we add variable type, Will give fatal error like:

Fatal Error : Type of Vendor\CustomShipping\Model\Carrier\Customshipping:$_code must not be defined

What changes do you propose?

Not required variable type declaration as it will be taken care by base class.

Anything else that can help to cover this?

No response

@github-project-automation github-project-automation bot moved this to 🆕 Ready for Grooming in Commerce - Issues Feb 29, 2024
@pawan
Copy link
Contributor Author

pawan commented Feb 29, 2024

@magento-docs @magento I am working on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Ready for Grooming
Development

No branches or pull requests

1 participant