Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sure this is the correct place, but How do I make the E-Sheep keep inside a Box like Div or Main? #26

Open
JesusGod-Pope666-Info opened this issue Sep 16, 2023 · 7 comments

Comments

@JesusGod-Pope666-Info
Copy link

So as I am making a new page and added a Sheep to it, I was thinking, how do I only get it to walk inside the main box? The Main box have everything pretty much inside of it, but the sheep would then walk on the bottom of the Topbar and the Scroll bar would not hide it either as walking on it and not inside of it.

Could you help me with that? It would be a further nice touch to it working on webpage.

By there way there still is some minor cliches on the "Rainbow" Sheeps some times, I think it is the bathing animation at least one but have not really kept my eyes unto it - but there are clearly some cliches here and there.

Beside that, pretty awesome script, although I find 1 Sheep walking around might be better then multiple as default.

Anyway, if you could help me out or have a solution, that would be awesome.

Or if you have an email or place I should reach out to you, that would be fine as well.

Dearly regards

  • Darkijah
@JesusGod-Pope666-Info
Copy link
Author

Here you can see the issues, I would like to have it run in the

box so it does not run in the topbar or inside the scrollbar:

Screenshot_2023-09-16_20-02-01
Screenshot_2023-09-16_20-01-48

@JesusGod-Pope666-Info
Copy link
Author

Still not a single Answer? :P

I would like to keep the Sheep away from the Right Scrollbar, and on top of the footer and below the menu bar at the top! Is this possible in any way?

Thanks.

@Adrianotiger
Copy link
Owner

Sorry for never giving you an answer!
It it not possible with the current code.

You can change the source code a little bit, changing this.screenW and this.screenH (line 116):
https://github.com/Adrianotiger/web-esheep/blob/master/src/esheep.js

A better solution would be, if you can set an element where to walk in (so you can put the pet inside a div or leave body as container). But this is not implemented. The code is easy to read, but I would like to rewrite it with some ES6 standards (like private members).

On line 720, you can find the checks for the borders (Y<0 means that the sheep reached the top. If you set this to 20 or 30, you can get what you expect).

I know, it is more a workaround. But at least, I wrote you back ;)

@JesusGod-Pope666-Info
Copy link
Author

Hey thanks for responding.

Yea I am not much of a coder, but I try my best. I will have a look, the Problem with the scroll bar I guess at the right, is that the mobile scrollbar is near not there, but on computers there is on, and I made a double size bar on my new test bar for easier catch for the mouse - I love it! While they do all there slimming madness in some browsers, like so much space is usually not used for the wideness of the page as you want it to be readable anyway so it makes no since slimming the standard scrollbar down. But they do all sorts of crazy things.

Maybe the top will work on both mobile and computer for the Top bar, and maybe the bottom if that is also possible - I guess the scollbar will then be an issue.

Yea it would be awesome if you could put the Sheep inside a Div or Main box, so it had its walls to play by, then the Scollbar I guess also could be fixed keeping it at the area one wanted.

Yea, I guess it might have been some time you since work on the project, although I know, always so many things to do.

Also would be nice if there was more that could make the sheep move upward, I might have an idea for making the website environment help on that that I think I will test in my test page some time. If you make some br's and make a whole in one side and use them consistently as breaks in the page information, and then flip the whole to the other side. One could then have some more points for the sheep to walk on and fall from the sides, while the information is somewhat still centered. Not sure how it will work, but it is worth a try. If then the sheep could do some rock climbing maybe on the screen to places that is possible to stand on, or be fired with a rocket upward to a point like a br line or box. So the sheep spreed more out on the screen as an overall thing. Could be pretty cool.

Thanks for the Sheep and your time.

-- Darkijah

@JesusGod-Pope666-Info
Copy link
Author

JesusGod-Pope666-Info commented Jun 6, 2024

But yea, if one made some br or boxes or box lines lines, maybe it could also be done with images fixing them inside a box, and divisions on the webpage, so the Sheep script have more to work with - it might help on making it more available to be less at the bottom. And I think one could make it so it both works on mobile and the computer. I will need to try it out at some point. br with holes to the left, middle and right as a division for articles on the page or something..... or inside text dividing it, must be possible.

It is primary br and boxes it can grab a hold on and stand on and all that, correct?

@JesusGod-Pope666-Info
Copy link
Author

Is there a forum for the Sheep some place?.... Would be nice, I see some Githubs projects have that - just so we can gather at one place on it.

@JesusGod-Pope666-Info
Copy link
Author

I think I found the primary forum, we can talk E Web Sheep as well in there? https://github.com/Adrianotiger/desktopPet/discussions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants