Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Universal App/w81 can't load DefaultHouseAd's SecondaryId? #51

Open
thkaw opened this issue Dec 23, 2014 · 2 comments
Open

Universal App/w81 can't load DefaultHouseAd's SecondaryId? #51

thkaw opened this issue Dec 23, 2014 · 2 comments

Comments

@thkaw
Copy link

thkaw commented Dec 23, 2014

Hi,
I'm testing DefaultHouseAd, and AppId can specific a URL that contain custom XAML.

but I try to setting DefaultHouseAd's SecondaryId, it will show error in Universal App project.
But not in W81 project:

w81, it seen like load specific XAML I made (AppId="http://www.ntex.tw/house.xaml1" is a wrong Link, simulate fail get custom ad XAML, correct is http://www.ntex.tw/house.xaml), But it still no failure-over AD show.
universal

Universal App have worse condition, it log seen like didn't get my specific XAML.
w81

MyHouseAd I try using UserControl or XAML Page, both didn't work.

I test DefaultHouseAd's SecondaryId in WP81Silverlight without any problem.

http://1drv.ms/1B0fip0
I upload those two project to onedrive, please help to guide how to set SecondaryId,

Thanks
@robwirving
Copy link
Contributor

Thanks for the repro project Nathaniel. I'm looking into this now.

robwirving added a commit that referenced this issue Jan 3, 2015
@robwirving
Fix Issue #51 with DefaultHouseAds
e9ae3b3 
Fixed two issues related to House Ads.

1. With a default house ad user control that has an extra period in it's
namespace such as: AdRotator.Examples.Windows8.1 Visual Studio decorates
the name by adding an underscore infront of this extra period. Our
reflection logic needs to account for this. When looking up the
AssemblyName we need to do our lookup without the added underscore, but
when resolving the classname we need to have the underscore. This
solution seems to work.

2. We were calling the async LoadCachedAd method from a catch block
which won't work because we can't await in a catch block
@SimonDarksideJ
Copy link
Contributor

Yo @thkaw, Rob has submitted a fix to the repo to resolve your issue.
Are you able to test for source or do you need an updated NuGet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thkaw @SimonDarksideJ @robwirving