Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests support #36

Open
pmarjan-onestic opened this issue May 8, 2024 · 0 comments
Open

Unit tests support #36

pmarjan-onestic opened this issue May 8, 2024 · 0 comments
Assignees
@candemiralp
Labels
enhancement Indicates new feature requests

Comments

@pmarjan-onestic
Copy link
Collaborator

The Adyen_Hyva module should be supported with PHP unit tests.
All PHP files should be supported in this kind of way.
Work would be done on a separate branch checkout out from the main one, and subsequently a PR will be opened for review purposes.

Side notes:
In a weekly meet, we have discarded the need of api-functional and integration tests, deciding to add only Unit tests as a complement to the end-to-end tests.
@pmarjan-onestic pmarjan-onestic added the enhancement Indicates new feature requests label May 8, 2024
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests
cfd22c8
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce ApplePayTest.php code duplication
5b4d63d
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce BrandsManagerTest.php code duplication
745e29f
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce PaymentMethodsTest.php code duplication
ddb2695
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce StoredCardsTest.php code duplication
5fd234c
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce CreditCardTest.php code duplication
5aa7a72
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce code duplication
3dcb8e3
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Reduce code duplication
985d812
pmarjan-onestic added a commit that referenced this issue May 15, 2024
@pmarjan-onestic
#36: Unit tests: Remove non needed vars
7a91c50
khushboo-singhvi added a commit that referenced this issue May 21, 2024
@pmarjan-onestic @khushboo-singhvi
#36: Unit tests (#39)
6df28e0 
* #36: Unit tests

* #36: Unit tests: Reduce ApplePayTest.php code duplication

* #36: Unit tests: Reduce BrandsManagerTest.php code duplication

* #36: Unit tests: Reduce PaymentMethodsTest.php code duplication

* #36: Unit tests: Reduce StoredCardsTest.php code duplication

* #36: Unit tests: Reduce CreditCardTest.php code duplication

* #36: Unit tests: Reduce code duplication

* #36: Unit tests: Reduce code duplication

* #36: Unit tests: Remove non needed vars

---------

Co-authored-by: Khushboo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@candemiralp candemiralp

Labels
enhancement Indicates new feature requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@candemiralp @pmarjan-onestic