Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V6 - Translation fallback #3038

Open
dimitriBouteille opened this issue Dec 24, 2024 · 1 comment
Open

V6 - Translation fallback #3038

dimitriBouteille opened this issue Dec 24, 2024 · 1 comment

Comments

@dimitriBouteille
Copy link
Contributor

dimitriBouteille commented Dec 24, 2024

Describe the bug

Since the update of the module on v6, I have only problems ...

If I am not mistaken, on v5 there was a fallback system to use the parent locale if the local passed as argument of AdyenCheckout did not exist. Thus:

AdyenCheckout({
	locale: 'fr_CH',
})

The local fr_CH (fr_CA, ...) does not exist in Adyen so it was the local fr_FR that is loaded.

On v6, if I pass the locale fr_CH, it is the translations en_US that are loaded...

Capture d’écran du 2024-12-24 15-37-13

To Reproduce

Steps to reproduce the behavior:

  1. Create card component with fr_CH or fr_CA locale
  2. 💥 The component

Expected behavior

The parent locale must be loaded :

  • fr_CH, fr_CA => fr_FR
  • it_CH => it_CH
  • de_AT, de_CH => de_DE
  • ...
@ashrafnazar
Copy link

I can confirm that I get errors in the network for en-GB.json as well. If the locale not included in the code, then the component breaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants