Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Multiple return values from a decorated function become a list #607

Open
1 of 3 tasks
zli11010 opened this issue Dec 27, 2024 · 2 comments
Open
1 of 3 tasks

[Bug]: Multiple return values from a decorated function become a list #607

zli11010 opened this issue Dec 27, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@zli11010
Copy link
Contributor

Contact Details

No response

📦 Package Version

0.3.18

🎞️ Framework Version

No response

🔎 Describe the Bug

If I do something like

@agentops.record_action("Action")
def some_action():
    return 0, 1

then the output becomes the list [0, 1].

This is an issue because I'm using a repository where they check whether the output from a function is a specific subclass of tuple, so when I added the decorator to the function the code broke.

🤝 Contribution

  • Yes, I'd be happy to submit a pull request with these changes.
  • I need some guidance on how to contribute.
  • I'd prefer the AgentOps team to handle this update.
@zli11010 zli11010 added the bug Something isn't working label Dec 27, 2024
@zli11010 zli11010 mentioned this issue Dec 27, 2024
Merged
@zli11010
Copy link
Contributor Author

I fixed the bug in this pr: #608

@areibman
Copy link
Contributor

Taking a look at the PR, thanks! @zli11010 are you using a specific project or rolling out an agent of your own?

teocns added a commit to zli11010/agentops that referenced this issue Jan 4, 2025
@teocns
test: Add tests to ensure @record_* decorators don't change return types
64fc5ab 
Added tests to verify PR AgentOps-AI#608, which fixes decorators changing tuple outputs
into lists. Checks:

1. Decorators keep the original return type for:
   - Simple tuples like (1, "test")
   - Named tuples like Point(x=1, y=2)
   - Nested tuples containing multiple values
   - Custom tuple types (fixing bug AgentOps-AI#607)

2. Tests also show that JSON handles tuples correctly without needing
   to convert them to lists first, proving the point that the
   conversion was unnecessary.
teocns added a commit that referenced this issue Jan 9, 2025
@zli11010 @the-praxs @teocns
[Fix] Removed unnecessarily changing tuple output to list output (#608)
ad5a17f 
* [Fix] Removed unnecessarily changing tuple output to list output

* Revert "[Fix] Removed unnecessarily changing tuple output to list output"

This reverts commit 829fa43.

* Fix multiple returns being modified by decorator

* test: Add tests to ensure @record_* decorators don't change return types

Added tests to verify PR #608, which fixes decorators changing tuple outputs
into lists. Checks:

1. Decorators keep the original return type for:
   - Simple tuples like (1, "test")
   - Named tuples like Point(x=1, y=2)
   - Nested tuples containing multiple values
   - Custom tuple types (fixing bug #607)

2. Tests also show that JSON handles tuples correctly without needing
   to convert them to lists first, proving the point that the
   conversion was unnecessary.

---------

Co-authored-by: Pratyush Shukla <[email protected]>
Co-authored-by: teocns <[email protected]>
Co-authored-by: Teo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@areibman @zli11010