From 565394bf94dcbab7ea340b7daf603f8dee326a14 Mon Sep 17 00:00:00 2001 From: Mehant Kammakomati Date: Wed, 13 Mar 2024 14:21:51 +0530 Subject: [PATCH] fix: atomic.Int64 requires go1.19 otherwise breaks (#1152) Signed-off-by: Mehant Kammakomati --- Dockerfile | 2 +- Makefile | 2 +- README.md | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Dockerfile b/Dockerfile index 3e83fd26c..3752b8972 100644 --- a/Dockerfile +++ b/Dockerfile @@ -23,7 +23,7 @@ RUN mkdir -p $GOPATH/src $GOPATH/bin && chmod -R 777 $GOPATH ENV PATH=$GOPATH/bin:/usr/local/go/bin:$PATH # Download Go. -ARG GO_VERSION=1.18 +ARG GO_VERSION=1.19 ARG TARGETARCH ARG TARGETOS ENV TARGETARCH_ENV=${TARGETARCH:-amd64} diff --git a/Makefile b/Makefile index e6a0dc163..ba0cf78b6 100644 --- a/Makefile +++ b/Makefile @@ -12,7 +12,7 @@ # See the License for the specific language governing permissions and # limitations under the License. -GO_VERSION ?= $(shell go run ./scripts/detectgoversion/detect.go 2>/dev/null || printf '1.18') +GO_VERSION ?= $(shell go run ./scripts/detectgoversion/detect.go 2>/dev/null || printf '1.19') BINNAME ?= move2kube IN_CICD ?= false CGO_ENABLED ?= 0 diff --git a/README.md b/README.md index 50f635fda..041d8cbab 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,7 @@ Checkout the [Tutorials](https://move2kube.konveyor.io/tutorials) and [Documenta To browse code [![Open in VSCode](https://badgen.net/badge/icon/Visual%20Studio%20Code?icon=visualstudio&label)](https://open.vscode.dev/konveyor/move2kube) -1. Obtain a recent version of `golang`. Known to work with `1.18`. +1. Obtain a recent version of `golang`. Known to work with `1.19`. 1. Ensure `$GOPATH` is set. If it's not set: 1. `mkdir ~/go` 1. `export GOPATH=~/go`