Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auro-button: update on-dark tertiary button hover color #236

Closed
leeejune opened this issue Dec 6, 2023 · 1 comment · Fixed by #228
Closed

auro-button: update on-dark tertiary button hover color #236

leeejune opened this issue Dec 6, 2023 · 1 comment · Fixed by #228
Assignees
@pgm369
Labels
auro-button not-reviewed Issue has not been reviewed by Auro team member Type: Feature New Feature

Comments

@leeejune
Copy link
Contributor

leeejune commented Dec 6, 2023

Is your feature request related to a problem? Please describe.

The tertiary button for the on-dark type should have the color ds-color-ui-bkg-hover-inverse: #FFFFFF0F (not sure if we should create ds-color-base-white-opacity-06).

Describe the solution you'd like

Add the design token either in the base category or as a hexadecimal value.

Describe alternatives you've considered

No response

Additional context

This issue is related to AlaskaAirlines/AuroDesignTokens#137

Exit criteria

No response
@leeejune leeejune added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team member auro-button labels Dec 6, 2023
@leeejune leeejune self-assigned this Dec 6, 2023
pgm369 added a commit that referenced this issue Dec 18, 2023
@pgm369
perf(hover): update tertiary hover color #236
a98f1db
@jordanjones243 jordanjones243 mentioned this issue Dec 29, 2023
Merged
6 tasks
jordanjones243 pushed a commit that referenced this issue Dec 29, 2023
@pgm369 @jordanjones243
perf(hover): update tertiary hover color #236
627a6b6
jordanjones243 pushed a commit that referenced this issue Jan 2, 2024
@pgm369 @jordanjones243
perf(hover): update tertiary hover color #236
2d346fa
blackfalcon pushed a commit that referenced this issue Jan 2, 2024
@semantic-release-bot
chore(release): 7.2.2 [skip ci]
62b3c76 
## [7.2.2](v7.2.1...v7.2.2) (2024-01-02)

### Bug Fixes

* **demo:** update surge demo branch ([5393ed9](5393ed9))
* **marked:** update marked package to script ([9ad605c](9ad605c))
* **tokens:** replace invalid tokens [#229](#229) ([7652913](7652913))

### Performance Improvements

* **accordion:** use new version of accordion ([eba6c1e](eba6c1e))
* **alert:** update to use auro-alert ([e18015c](e18015c))
* **deps:** update dependencies ([7daaf28](7daaf28))
* **eslint:** install auro eslint rules ([d9fd3ed](d9fd3ed))
* **focus:** remove focus-visible support ([c0511e5](c0511e5))
* **hover:** update hover css rules ([f64446d](f64446d))
* **hover:** update secondary hover color [#227](#227) ([1eff68d](1eff68d))
* **hover:** update tertiary hover color [#236](#236) ([2d346fa](2d346fa))
* **jsdocs:** update jsdocs ([ebec779](ebec779))
* **node:** update to support node 20 ([816d29e](816d29e))
* **tokens:** add css fallbacks for tokens [#229](#229) ([423502b](423502b))
* **token:** update design token names [#229](#229) ([f94ab5d](f94ab5d))
@jordanjones243 jordanjones243 linked a pull request Jan 3, 2024 that will close this issue
Update tokens based on new theming convention #228
Merged
6 tasks
@jordanjones243
Copy link
Contributor

This ticket was addressed as a part of this PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgm369 pgm369

Labels
auro-button not-reviewed Issue has not been reviewed by Auro team member Type: Feature New Feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update tokens based on new theming convention AlaskaAirlines/auro-button
5 participants
@blackfalcon @jordanjones243 @leeejune @Patrick-Daly-AA @pgm369