Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-button: tier 2 & 3 tokens needed #243

Closed
6 tasks done
braven112 opened this issue Jan 18, 2024 · 0 comments · Fixed by #251
Closed
6 tasks done

auro-button: tier 2 & 3 tokens needed #243

braven112 opened this issue Jan 18, 2024 · 0 comments · Fixed by #251
Assignees
Labels
auro-button not-reviewed Issue has not been reviewed by Auro team member Type: Feature New Feature

Comments

@braven112
Copy link
Member

braven112 commented Jan 18, 2024

Is your feature request related to a problem? Please describe.

This lists all of the tokens that need to be updated. There will likely need to be some new ones created in addition to this list. Please see this issue for some of the new tokens that need to be created for gradient support

The following lines need to be updated to support theming

$auro-rgb-color-base-black-03: rgba(0, 0, 0, .03);

$auro-rgb-color-base-white-03: rgba(255, 255, 255, .03);

https://github.com/AlaskaAirlines/auro-button/blob/4b18af8d691f7100c73b2565bc6e22adfa092067/src/style.scss#L66C4-L66C19

Needs to use a tier 2 semantic token to be used across repos or a tier 3 component level token

min-height: var(--ds-size-600, $ds-size-600);

max-height: var(--ds-size-600, $ds-size-600);

gap: var(--ds-size-100, $ds-size-100);

border: 1px solid transparent;

width: calc(var(--ds-size-300, $ds-size-300) - var(--ds-size-50, $ds-size-50));

height: calc(var(--ds-size-300, $ds-size-300) - var(--ds-size-50, $ds-size-50));

padding-left: var(--ds-size-50, $ds-size-50);

padding-right: var(--ds-size-50, $ds-size-50);

box-shadow: var(--ds-elevation-300, $ds-elevation-300);

height: var(--ds-size-500, $ds-size-500);

width: var(--ds-size-300, $ds-size-300);

height: var(--ds-size-300, $ds-size-300);

width: var(--ds-size-600, $ds-size-600);

Should be converted from SASS to a tier 2 token

background-color: rgba($ds-color-ui-default-default, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-default, 0);

color: rgba($ds-color-text-link-default, $disabledOPacity);

background-color: rgba($ds-color-background-lightest, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-default, $disabledOPacity);

color: rgba($ds-color-text-link-default, $disabledOPacity);

background-color: rgba($ds-color-background-lightest, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-default, $disabledOPacity);

background-color: $auro-rgb-color-base-black-03;

color: rgba($ds-color-text-link-default, $disabledOPacity);

background-color: $auro-rgb-color-base-black-03;

color: rgba($ds-color-text-primary-default, $disabledOPacity);

background-color: rgba($ds-color-ui-default-inverse, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-inverse, $disabledOPacity);

color: rgba($ds-color-text-primary-default, $disabledOPacity);

background-color: rgba($ds-color-ui-default-inverse, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-inverse, $disabledOPacity);

color: rgba($ds-color-ui-default-inverse, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-inverse, $disabledOPacity);

color: rgba($ds-color-ui-default-inverse, $disabledOPacity);

border: 1px solid rgba($ds-color-ui-default-inverse, $disabledOPacity);

background-color: $auro-rgb-color-base-white-03;

background-color: $auro-rgb-color-base-white-03;

color: rgba($ds-color-ui-default-inverse, $disabledOPacity);

background-color: $auro-rgb-color-base-white-03;

color: rgba($ds-color-ui-default-inverse, $disabledOPacity);

background-image: linear-gradient(var(--ds-color-ui-hover-default, $ds-color-ui-hover-default), var(--ds-color-ui-hover-default, $ds-color-ui-hover-default));

border: 1px solid var(--ds-color-ui-hover-default, $ds-color-ui-hover-default);

Should use a new tier 2 token. Currently the token describes the value since it references "Darkest" or "Lightest"
color: var(--ds-color-background-darkest, $ds-color-background-darkest, $ds-color-background-darkest);

background-color: var(--ds-color-background-lightest, $ds-color-background-lightest);

background-color: var(--ds-color-background-darker, $ds-color-background-darker);

background-color: var(--ds-color-background-darker, $ds-color-background-darker);

background-color: var(--ds-color-background-darker, $ds-color-background-darker);

background-color: var(--ds-color-background-darker, $ds-color-background-darker);

Missing background-image property to support gradients:


&--secondary {

&:active {

background-color: var(--ds-color-ui-default-inverse, $ds-color-ui-default-inverse);

background-color: var(--ds-color-background-darker, $ds-color-background-darker);

&:active {

&:hover {

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

Exit criteria

@braven112 braven112 added Type: Feature New Feature not-reviewed Issue has not been reviewed by Auro team member auro-button labels Jan 18, 2024
@braven112 braven112 changed the title auro-button: Semantic tokens auro-button: tier 2 & 3 tokens needed Jan 19, 2024
@jason-capsule42 jason-capsule42 self-assigned this May 29, 2024
@jason-capsule42 jason-capsule42 linked a pull request May 29, 2024 that will close this issue
24 tasks
blackfalcon pushed a commit that referenced this issue Jul 3, 2024
# [7.3.0-beta.1](v7.2.9...v7.3.0-beta.1) (2024-07-03)

### Features

* **flat:** add new flat variant for use in auro-components ([49a6bcf](49a6bcf))
* **themes:** update styles to support component themes [#243](#243) ([699def3](699def3))

### Performance Improvements

* **loader:** use beta version of loader as direct dependency ([a7ca9de](a7ca9de))
DukeFerdinand pushed a commit that referenced this issue Aug 21, 2024
* **flat:** add new flat variant for use in auro-components ([49a6bcf](49a6bcf))
* **themes:** update styles to support component themes [#243](#243) ([699def3](699def3))

* **loader:** use beta version of loader as direct dependency ([a7ca9de](a7ca9de))
blackfalcon pushed a commit that referenced this issue Sep 10, 2024
# [7.3.0-beta.7](v7.3.0-beta.6...v7.3.0-beta.7) (2024-09-10)

### Bug Fixes

* **hover:** remove disabled hover UI [#256](#256) ([a46ac93](a46ac93))

### Features

* **themes:** update styles to support component themes [#243](#243) ([f307e92](f307e92))
jason-capsule42 pushed a commit that referenced this issue Sep 10, 2024
* **flat:** add new flat variant for use in auro-components ([49a6bcf](49a6bcf))
* **themes:** update styles to support component themes [#243](#243) ([699def3](699def3))

* **loader:** use beta version of loader as direct dependency ([a7ca9de](a7ca9de))
jason-capsule42 pushed a commit that referenced this issue Sep 10, 2024
* **flat:** add new flat variant for use in auro-components ([49a6bcf](49a6bcf))
* **themes:** update styles to support component themes [#243](#243) ([699def3](699def3))

* **loader:** use beta version of loader as direct dependency ([a7ca9de](a7ca9de))
blackfalcon pushed a commit that referenced this issue Sep 10, 2024
# [7.3.0](v7.2.10...v7.3.0) (2024-09-10)

### Bug Fixes

* **flat:** change width CSS rules to 'unset' for the flat variant ([610dd4b](610dd4b))
* **flat:** correct colors in ondark flat variant ([2e34651](2e34651))
* **flat:** remove focus border from flat variant ([1b6acb7](1b6acb7))

### Features

* **flat:** add new flat variant for use in auro-components ([afb87d3](afb87d3))
* force new feature release ([ec4c6f1](ec4c6f1))
* **themes:** update styles to support component themes [#243](#243) ([acc481e](acc481e))

### Performance Improvements

* **flat:** use the correct new tokens for the flat variant [#252](#252) ([349edc3](349edc3))
* **loader:** use beta version of loader as direct dependency ([7e925af](7e925af))
* update design tokens and eslint config ([cfefc60](cfefc60))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auro-button not-reviewed Issue has not been reviewed by Auro team member Type: Feature New Feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants